Bump to StructArmed ^0.15 and enable MustBeFinalRule#8197
Conversation
|
@TomasVotruba ready 👍 |
|
Rebased with skip not needed change pattern paths 👍 @TomasVotruba ready to merge 👍 |
|
Pesonally, I think using PHPStan and other tool we have here is good enough 👍 Could be better, but it's good enough. I want to avoid adding more tooling to keep it easy and fun to use so I'm closing this. Can you make this part of PHPStan? |
|
It not more tooling, it something already included in structarmed, just enabling one of its rule, that has ability to check if class has children. I think for phpstan, it seems require collector first... |
|
I'm considering dropping it and one more. To much attention stealing for little gain. Like having Psalm, PHPStan and Mago at the same time. Costly maintenance. |
|
I gave it a try but seems the value is very little over another dev tool we have to maintain. |
StructArmed 0.15.0 introduce
ExtendedClassAwareRuleInterfacethat makes itsMustBeFinalRulesafely be used to skip if there is class that extend target class.This PR bump StructArmed to
^0.15and apply theMustBeFinalRulewith single command to fix.