Skip to content

Bump to StructArmed ^0.15 and enable MustBeFinalRule#8197

Closed
samsonasik wants to merge 3 commits into
mainfrom
finalize
Closed

Bump to StructArmed ^0.15 and enable MustBeFinalRule#8197
samsonasik wants to merge 3 commits into
mainfrom
finalize

Conversation

@samsonasik

Copy link
Copy Markdown
Member

StructArmed 0.15.0 introduce ExtendedClassAwareRuleInterface that makes its MustBeFinalRule safely be used to skip if there is class that extend target class.

This PR bump StructArmed to ^0.15 and apply the MustBeFinalRule with single command to fix.

vendor/bin/structarmed analyze --fix

@samsonasik
samsonasik requested a review from TomasVotruba July 20, 2026 14:56
@samsonasik

Copy link
Copy Markdown
Member Author

@TomasVotruba ready 👍

@samsonasik

Copy link
Copy Markdown
Member Author

Rebased with skip not needed change pattern paths 👍

@TomasVotruba ready to merge 👍

@TomasVotruba

Copy link
Copy Markdown
Member

Pesonally, I think using PHPStan and other tool we have here is good enough 👍 Could be better, but it's good enough. I want to avoid adding more tooling to keep it easy and fun to use so I'm closing this.

Can you make this part of PHPStan?

@samsonasik

Copy link
Copy Markdown
Member Author

It not more tooling, it something already included in structarmed, just enabling one of its rule, that has ability to check if class has children.

I think for phpstan, it seems require collector first...

@TomasVotruba

Copy link
Copy Markdown
Member

I'm considering dropping it and one more. To much attention stealing for little gain.

Like having Psalm, PHPStan and Mago at the same time. Costly maintenance.

@TomasVotruba
TomasVotruba deleted the finalize branch July 24, 2026 09:07
@TomasVotruba

Copy link
Copy Markdown
Member

I gave it a try but seems the value is very little over another dev tool we have to maintain.
Sorry, but dropping it: #8205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants