[DeadCode] Add RemoveDefaultValueFromAssignedPropertyRector#8207
Merged
Conversation
TomasVotruba
force-pushed
the
remove-null-default-assigned-property
branch
from
July 24, 2026 10:58
7f3434a to
a7d2850
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9822
A property with a redundant default value is never given
readonlybyReadOnlyPropertyRector, because the default value blocks it. The default is dead: the property is always overwritten in the constructor.This rule removes that redundant default from typed properties that are unconditionally assigned in the constructor, so downstream rules (like
ReadOnlyPropertyRector) start working as expected.final class SomeClass { - private ?SomeType $someType = null; + private ?SomeType $someType; public function __construct(SomeType $someType) { $this->someType = $someType; } }Any default is dead, not only
= null:final class SomeClass { - private int $value = 5; + private int $value; public function __construct(int $value) { $this->value = $value; } }Scope / guards:
= nullis already handled byRemoveNullPropertyInitializationRector.