[DeadCode] Skip static property in RemoveDefaultValueFromAssignedPropertyRector - #8240
Merged
Merged
Conversation
Member
Author
|
Packagist is down, but feature is correct 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A static property is shared per class, not per instance. Removing its default value makes it uninitialized until the first constructor call, so any read before that (or without ever instantiating the class) throws
Error: Typed static property must not be accessed before initialization.ConstructorAssignDetectormatchesStaticPropertyFetchas well asPropertyFetch, soself::$value = $value;in the constructor was treated as "always assigned" and the default was dropped.final class SkipStaticProperty { - private static ?int $value = null; + private static ?int $value; public function __construct(int $value) { self::$value = $value; } public static function getValue(): ?int { return self::$value; } }SkipStaticProperty::getValue()throws after the change, without ever constructing the class.Static properties are now skipped.