[CodingStyle] Deprecate NestedTernaryToMatchRector - #8241
Merged
Conversation
The rule is not part of any set, so it only runs when registered by hand. On top of that, match(true) over nested conditions is often less readable and more confusing than the ternary it replaces - explicit intent, e.g. early returns or a named method, is the better refactoring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NestedTernaryToMatchRectoris not part of any set - it only runs when registered by hand.Beyond that, the output is rarely an improvement.
match (true)over nested conditions reads as a lookup table while it is really a chain of unrelated boolean tests, so the intent gets less obvious, not more:Both versions hide the same problem. The useful refactoring is explicit intent - early returns or a named method - which no rule can decide for you.
Standard deprecation shape: implements
DeprecatedInterface,refactor()throws, tests removed. TheConditionAndResultvalue object goes with it, it had no other use.