[depre] Remove strict-booleans set deprecated since 2025-10 - #8243
Merged
Conversation
The set has been deprecated for 9 months and shrank to a single rule, DisallowedEmptyRuleFixerRector, which the code-quality set already registers. The "strictBooleans" flag of withPreparedSets() only printed a warning, it never added the set to the config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
strict-booleansset was deprecated on 2025-10-21 in #7523 - 9 months ago. Since that cleanup it holds exactly one rule:That rule is already registered in
CodeQualityLevel, so the set adds nothing the code-quality set does not already give you.The
strictBooleansflag ofwithPreparedSets()was already inert - it printed a deprecation warning and was never part of$setMap, so it never applied any rule:Removed here:
config/set/strict-booleans.phpSetList::STRICT_BOOLEANSstrictBooleansparam and its warning block inRectorConfigBuilderStrict Booleansentry inCoreSetProviderDisallowedEmptyRuleFixerRectoritself stays, reachable through the code-quality set.Note this is a BC break for configs still naming
SetList::STRICT_BOOLEANSor passingstrictBooleans: true- they now fail instead of warning.ECS, PHPStan, Rector and PHPUnit (5472 tests) pass.