Skip to content

[ChangesReporting] Remove junit output format - #8249

Closed
TomasVotruba wants to merge 2 commits into
mainfrom
remove-junit-output-formatter
Closed

[ChangesReporting] Remove junit output format#8249
TomasVotruba wants to merge 2 commits into
mainfrom
remove-junit-output-formatter

Conversation

@TomasVotruba

Copy link
Copy Markdown
Member

Rector is a refactoring tool, not a testing tool, so reporting its results as a JUnit test suite is a poor fit. The gitlab and github output formats already cover CI reporting.

Before

vendor/bin/rector --dry-run --output-format=junit
<?xml version="1.0" encoding="UTF-8"?>
<testsuite name="rector" tests="1" failures="1">
  <testcase name="src/SomeClass.php" file="src/SomeClass.php">
    <error type="error">...diff...</error>
  </testcase>
</testsuite>

After

vendor/bin/rector --dry-run --output-format=gitlab
vendor/bin/rector --dry-run --output-format=github

Removes JUnitOutputFormatter and its container registration, plus an UPGRADING.md note.

…rocess filter

A rule registered by multiple sets was tagged repeatedly, so the same singleton
was handed out N times: run N times per node, and listed N times in reports.

Also adds the --composer-based process option and the composer-bound rule
configuration report.
Rector is a refactoring tool, not a testing tool, so reporting its
results as a JUnit test suite is a poor fit. The gitlab and github
output formats already cover CI reporting.

Removes JUnitOutputFormatter and its container registration.
@TomasVotruba

Copy link
Copy Markdown
Member Author

Superseded by #8250, which contains only the junit removal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant