[DeadCode] Skip RemoveDefaultValueFromAssignedPropertyRector on early return in constructor-called method - #8261
Merged
TomasVotruba merged 1 commit intoAug 2, 2026
Conversation
… return in constructor-called method
TomasVotruba
enabled auto-merge (squash)
August 2, 2026 10:42
TomasVotruba
deleted the
fix-default-value-early-return-in-called-method
branch
August 2, 2026 10:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RemoveDefaultValueFromAssignedPropertyRectoralready bails out when the constructor itself contains areturn, since the assign can be skipped. But the property may also be assigned in a method called from the constructor - and that method can early return too.Reported on this real-world case (Mautic
Fetcher), where[]was wrongly removed from$unknownLeadIds/$unknownContactIds:class Fetcher { - private array $unknownLeadIds = []; + private array $unknownLeadIds; public function __construct(...) { $this->fetchLeads(); } private function fetchLeads(): void { if (!$campaignMembers = $this->organizer->getLeadIds()) { return; // <-- assign never happens, property stays uninitialized } // ... $this->unknownLeadIds = array_values(array_diff($campaignMembers, $this->knownLeadIds)); } }After the change the whole class is skipped, as
fetchLeads()may return before the assign.