[CodeQuality] Deprecate SwitchNegatedTernaryRector - #8283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecates
SwitchNegatedTernaryRector.The rule flips
! $cond ? A : Binto$cond ? B : A. The condition gets positive, but the branch values swap places — and that ordering often carried meaning.Simple case is fine:
Nested case is where it turns:
The original reads guard-first: bail value
[]up top, complex branch last. After the rule, the nested ternary is jammed into the?branch and the trivial fallback sits at the bottom. Also note([])— parentheses added around a plain array literal.Second fixture had the same artifact:
($a)— parentheses around a bare variable.Which form reads better depends on what the values mean, not on the shape of the condition. That is a personal preference, so the rule is deprecated rather than patched.
Changes:
SwitchNegatedTernaryRectorimplementsDeprecatedInterface,refactor()throwsCodeQualityLeveltests/Issues/Issue6480(which existed only to cover this rule's interplay withRemoveDeadInstanceOfRector) removedRemoveUselessTernaryRector