[Sets] Update SetManagerTest to the single Twig composer-based set - #8294
Closed
TomasVotruba wants to merge 1 commit into
Closed
[Sets] Update SetManagerTest to the single Twig composer-based set#8294TomasVotruba wants to merge 1 commit into
TomasVotruba wants to merge 1 commit into
Conversation
rectorphp/rector-symfony#1010 trims TwigSetProvider to its composer-based trigger, as every rule of the per-version Twig sets is already in it, bound to the twig/twig version it needs.
Member
Author
|
Folded into #8293, so that PR is green on its own. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #8292, fixes the 4
SetManagerTestfailures on main.rectorphp/rector-symfony#1010 is merged, so
TwigSetProvidernow registers only its composer-based trigger. The per-version Twig sets were dropped there because every rule in them is already inconfig/sets/twig/composer-based.php, bound to the exacttwig/twigversion it needs — so a Twig 2.0 project still gets exactly the rules it got before, just from one set instead of three.tests/Setgreen: 12 tests, 15 assertions.