Skip to content

[Testing] Remove stray bare .php fixture leftover - #8308

Merged
TomasVotruba merged 1 commit into
mainfrom
remove-stray-fixture
Aug 6, 2026
Merged

[Testing] Remove stray bare .php fixture leftover#8308
TomasVotruba merged 1 commit into
mainfrom
remove-stray-fixture

Conversation

@TomasVotruba

Copy link
Copy Markdown
Member

FixtureAddToInterfaceMethods/interface_implement.php is a leftover duplicate: it contains only the "before" half of interface_implement.php.inc, which already exists next to it and is the fixture actually used.

Being a bare .php in a dir not named Fixture/, it is not auto-skipped by ECS, so it fails check-cs on main:

1) rules-tests/Php83/Rector/ClassMethod/AddOverrideAttributeToOverriddenMethodsRector/FixtureAddToInterfaceMethods/interface_implement.php

Removing it makes ECS green again. AddOverrideAttributeToOverriddenMethodsRector tests still pass (38 tests).

@TomasVotruba
TomasVotruba merged commit 8b2ff23 into main Aug 6, 2026
64 checks passed
@TomasVotruba
TomasVotruba deleted the remove-stray-fixture branch August 6, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant