[phpstan] Cleanup phpstan errors

.github/workflows/tests.yaml

@@ -6,8 +6,6 @@ on:
      branches:
         - main
 
-
-
 env:
     # see https://github.com/composer/composer/issues/9368#issuecomment-718112361
     COMPOSER_ROOT_VERSION: "dev-main"
@@ -39,35 +37,3 @@ jobs:
             -   uses: "ramsey/composer-install@v4"
 
             -   run: vendor/bin/fastunit tests rules-tests utils/phpstan/tests
-
-    # optional fast feedback on pull requests: run only the tests whose static
-    # dependency closure changed. NOT a merge gate -- the full "tests" job above
-    # stays authoritative, since -tia over-approximates but cannot see dynamic
-    # (reflection / class-string) dependencies.
-    tests_tia:
-        if: github.event_name == 'pull_request'
-        runs-on: ubuntu-latest
-        timeout-minutes: 4
-
-        name: PHP 8.4 tests (impacted only)
-        steps:
-            -   uses: actions/checkout@v5
-
-            # restore the newest cached hash snapshot; save a fresh one per commit
-            -   uses: actions/cache@v4
-                with:
-                    path: .fastunit-cache
-                    key: fastunit-tia-${{ github.sha }}
-                    restore-keys: |
-                        fastunit-tia-
-
-            -
-                uses: shivammathur/setup-php@v2
-                with:
-                    php-version: '8.4'
-                    coverage: none
-                    ini-values: zend.assertions=1
-
-            -   uses: "ramsey/composer-install@v4"
-
-            -   run: vendor/bin/fastunit -tia tests rules-tests utils/phpstan/tests

composer.json

@@ -53,8 +53,7 @@
         "rector/swiss-knife": "^2.4.1",
         "shipmonk/composer-dependency-analyser": "^1.8",
         "symplify/easy-coding-standard": "^13.2.13",
-        "symplify/phpstan-extensions": "^12.0.2",
-        "symplify/phpstan-rules": "^14.12",
+        "symplify/phpstan-rules": "^14.12.3",
         "tomasvotruba/class-leak": "^2.1",
         "tomasvotruba/fast-unit": "^0.1",
         "tomasvotruba/type-coverage": "^2.3",
@@ -106,7 +105,6 @@
             "@test"
         ],
         "test": "vendor/bin/fastunit tests rules-tests utils/phpstan/tests",
-        "test-tia": "vendor/bin/fastunit -tia tests rules-tests utils/phpstan/tests",
         "check-cs": "vendor/bin/ecs check --ansi",
         "fix-cs": "vendor/bin/ecs check --fix --ansi",
         "phpstan": "vendor/bin/phpstan analyse --ansi --memory-limit=512M",