Revert "[Testing] Use fresh single-file source locator under PHPUnit" (#8464) - #8465
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #8464.
That change did not actually fix the order-dependent reflection failure it targeted. It only appeared green on its own branch because that branch's
fastunitchunk layout happened to avoid the failing test grouping - the same masking effect as adding or removing test classes. With a different chunk layout the original failure still reproduces, so the fresh-locator switch was not the real root cause.Reverting to avoid carrying an ineffective change in the test harness. The underlying order-dependent reflection issue still needs a proper root-cause fix.