[composer-based] Add AuthorizationCheckerIsGrantedExtractorRector to the composer-based set - #985
Merged
Merged
Conversation
…the composer-based set Bond the rule to symfony/security-core >=4.4, the version that deprecated passing multiple attributes to AuthorizationCheckerInterface::isGranted(). symfony/security-core is already a registered ComposerTriggeredSet package from >=4.3, so no set provider change is needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bonds
AuthorizationCheckerIsGrantedExtractorRectortosymfony/security-core >=4.4viaComposerPackageConstraintInterface, and registers it inconfig/sets/symfony/composer-based.php.4.4 is the version that deprecated passing multiple attributes to
AuthorizationCheckerInterface::isGranted(), see UPGRADE-4.4.md#security.symfony/security-coreis already a registeredComposerTriggeredSetpackage from>=4.3, soSymfonySetProviderneeds no change.What the rule does
use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface; final class SomeController { public function __construct( private AuthorizationCheckerInterface $authorizationChecker ) { } public function hasAccess(): bool { - return $this->authorizationChecker->isGranted(['ROLE_USER', 'ROLE_ADMIN']); + return $this->authorizationChecker->isGranted('ROLE_USER') || $this->authorizationChecker->isGranted('ROLE_ADMIN'); } }Added a
tests/ComposerBasedfixture so the bonding is verified through the set itself, not only through the rule's own test.