[Deprecation] Deprecate ReturnDirectJsonResponseRector

[TomasVotruba]

ReturnDirectJsonResponseRector collapses a JsonResponse assignment plus setData() into a single constructor call:

 class SomeController extends AbstractController
 {
     public function index()
     {
-        $response = new JsonResponse();
-        $response->setData(['key' => 'value']);
-
-        return $response;
+        return new JsonResponse(['key' => 'value']);
     }
 }

Why deprecate

The rule matches on statement position, not on the full statement list between the assignment and the return. Anything else touching the response gets hoisted past:

public function index()
{
    $response = new JsonResponse();
    $response->setCallback('handleData');   // JSONP
    $response->setData(['key' => 'value']);

    return $response;
}

setData() re-encodes the payload and re-applies the callback, so ordering is load-bearing here. The rule rewrites it to return new JsonResponse(['key' => 'value']); and silently drops the setCallback() statement position semantics. Same class of problem for setStatusCode() and $response->headers->set() sequences.

Hardening it means teaching the rule about every JsonResponse setter and bailing on any interleaved statement — a lot of surface for a change that saves one line and no behavior.

Why now

The rule was never actually shipped. It sat commented out in symfony-code-quality.php:

// enable once tested
// ReturnDirectJsonResponseRector::class,

so it is registered in no set, reachable only by direct registration, and covered by a single fixture. No version constraint is involved — JsonResponse::__construct($data) and setData() both exist since Symfony 2.1.

Changes

• rule keeps its class and RuleDefinition, implements DeprecatedInterface, refactor() throws
• commented-out entry removed from symfony-code-quality.php
• test, fixture and rule config deleted

ControllerMethodAnalyzer and ResponseClass::JSON stay — both still used by other rules.