[CodeQuality] Add LoadValidatorMetadataToAttributeRector, deprecate the annotation variant

[TomasVotruba]

LoadValidatorMetadataToAnnotationRector moves loadValidatorMetadata() into a docblock. Per the vendored symfony/validator CHANGELOG:

• 5.2.0 — "enabled the validator to load constraints from PHP attributes"
• 6.4 — "Deprecate Doctrine annotations support in favor of native attributes", AnnotationLoader → AttributeLoader

So the rule emits a form Symfony deprecated two majors ago. This replaces it with an attribute-writing rule.

Before / after

 final class SomeClass
 {
-    private $city;
-
-    public static function loadValidatorMetadata(ClassMetadata $metadata): void
-    {
-        $metadata->addPropertyConstraint('city', new Assert\NotBlank([
-            'message' => 'City can\'t be blank.',
-        ]));
-    }
+    #[Assert\NotBlank(message: 'City can\'t be blank.')]
+    private $city;
 }

Getter constraints land on the getter, class constraints on the class, and the loadValidatorMetadata() method is dropped once every statement has moved.

Placement is checked, not assumed

Presence of #[Attribute] alone is not enough — the target flags differ per constraint, and the rule writes to three different places:

// NotBlank.php:24
#[\Attribute(\Attribute::TARGET_PROPERTY | \Attribute::TARGET_METHOD | \Attribute::IS_REPEATABLE)]

// Callback.php:22
#[\Attribute(\Attribute::TARGET_CLASS | \Attribute::TARGET_PROPERTY | \Attribute::TARGET_METHOD | \Attribute::IS_REPEATABLE)]

Only 10 of the 70 constraints in symfony/validator allow TARGET_CLASS. Writing #[Assert\NotBlank] on a class would crash the validator on load, so ConstraintAttributeTargetAnalyzer checks the flags for each placement:

// skipped - NotBlank does not target classes
$metadata->addConstraint(new Assert\NotBlank());

The same check covers custom constraints written before 5.2, which carry no #[Attribute] and would fail with "Attempting to use non-attribute class" once the loader instantiates them:

// skipped - no #[Attribute] on the constraint
$metadata->addPropertyConstraint('city', new NonAttributeConstraint());

Anything that cannot be placed stays in loadValidatorMetadata(), so a partial move keeps the method:

 final class PartialMoveKeepsClassMethod
 {
+    #[\Symfony\Component\Validator\Constraints\NotBlank]
     private $city;

     public static function loadValidatorMetadata(ClassMetadata $metadata): void
     {
-        $metadata->addPropertyConstraint('city', new Assert\NotBlank());
         $metadata->addPropertyConstraint('unknownProperty', new Assert\NotBlank());
     }
 }

Named arguments

The options array is emitted as named arguments, matching what ConstraintOptionsToNamedArgumentsRector (symfony73-validator) produces for new expressions. That rule operates on New_ and cannot reach attribute args, so without this the new rule would emit a form the repo has another rule to eliminate.

#[\Symfony\Component\Validator\Constraints\CardScheme(schemes: ['VISA', 100])]

A non-string key or a list (new Assert\Callback(['validateCity'])) keeps the array verbatim — there the array is the value, not options.

Version binding

ComposerPackageConstraintInterface → symfony/validator >= 5.2. Registered in symfony-code-quality only, replacing the old rule. The constraint gates the rule at runtime wherever it is registered, so composer-based is left untouched.

Deprecation

LoadValidatorMetadataToAnnotationRector keeps its class and RuleDefinition, implements DeprecatedInterface, refactor() throws pointing at the new rule.

Its support classes had no other callers and are removed: ClassAnnotationAssertResolver, MethodCallAnnotationAssertResolver, PropertyAnnotationAssertResolver, DoctrineAnnotationFromNewFactory, DoctrineAnnotationKeyToValuesResolver, StringValueQuoteWrapper, ClassMethodAndAnnotation, PropertyAndAnnotation. StmtMethodCallMatcher is reused by the new resolver and moved to NodeAnalyzer/ValidatorAssert/. AnnotationOrAttributeValueResolver stays — still used by ThisRenderFactory.