Allow later versions of nette/utils#1322
Closed
sanmai wants to merge 1 commit intorectorphp:masterfrom
sanmai:patch-1
Closed
Allow later versions of nette/utils#1322sanmai wants to merge 1 commit intorectorphp:masterfrom sanmai:patch-1
sanmai wants to merge 1 commit intorectorphp:masterfrom
sanmai:patch-1
Conversation
Contributor
Author
|
PHPStan sees some trouble, but it's unrelated to nette/utils: builds on master fail with the very same error. |
Member
|
Could you fix it anyway? |
Contributor
Author
|
How about not in this PR? It's kind hard on mobile. Thank you very much. |
Member
|
Sure, feel free to open new one |
Member
|
Replaced by #1323 Thank you for the PR though |
Contributor
Author
|
No problem, but if you could push a release with that fix... it’ll be great! |
Member
|
I plan it in a week with bunch of other fixes. In the meantime this is how you make dependencies work: {
"nette/utils": "3.0 as 2.5"
} |
TomasVotruba
added a commit
that referenced
this pull request
Nov 27, 2021
rectorphp/rector-src@3844627 [DX] make all configure() methods accept direct value object configuration (#1322)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be a no brainer. Let's see if CI tests pass.