allow Nette 3.0#1323
Merged
TomasVotruba merged 2 commits intorectorphp:masterfrom Apr 16, 2019
mimmi20:master
Merged
Conversation
Member
|
Thanks 👍 It usually takes 4-5 mins. In this PR it's 6 mins:
Where is 25 mins? That would mean something is wrong |
Contributor
Author
|
|
Member
|
Could you share link? |
Contributor
|
This got to be a glitch. Like, sometimes Composer can’t do its thing on time., or the like. Should be in the logs. |
Contributor
Author
https://travis-ci.com/mimmi20/rector/jobs/193220853 I hope you can see this. |
Member
|
Yes I can, for open source projects it's always public. Probably some glitch in the Matrix. If it happens again, let me know |
TomasVotruba
added a commit
that referenced
this pull request
Nov 28, 2021
rectorphp/rector-src@3f6f706 [DeadCode] Add RemoveDeadContinueRector (#1323)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to test this tool, but I require Nette 3.0.
By the way, Is it normal that your PHPUnit coverage tests require more than 25 minutes on travis ci?