Skip to content

🎉 Rule #300 - [CodeQuality] Add CompleteDynamicPropertiesRector#1488

Merged
TomasVotruba merged 3 commits intomasterfrom
php-dynamic-props
May 26, 2019
Merged

🎉 Rule #300 - [CodeQuality] Add CompleteDynamicPropertiesRector#1488
TomasVotruba merged 3 commits intomasterfrom
php-dynamic-props

Conversation

@TomasVotruba
Copy link
Copy Markdown
Member

@TomasVotruba TomasVotruba commented May 26, 2019

Closes #1476

In PHP 7.3-

 class SomeClass
 {
+    /**
+     * @var string
+     */
+    public $outputFormat;

     public function run()
     {
         $this->outputFormat = 'name';
     }
 }

In PHP 7.4+

 class SomeClass
 {
+    public string $outputFormat;

     public function run()
     {
         $this->outputFormat = 'name';
     }
 }

@TomasVotruba TomasVotruba changed the title [CodeQuality] Add CompleteDynamicPropertiesRector [CodeQuality] Add CompleteDynamicPropertiesRector - rule #300 🎆 May 26, 2019
@TomasVotruba TomasVotruba changed the title [CodeQuality] Add CompleteDynamicPropertiesRector - rule #300 🎆 [CodeQuality] Add CompleteDynamicPropertiesRector - rule #300 🎉 May 26, 2019
@TomasVotruba TomasVotruba changed the title [CodeQuality] Add CompleteDynamicPropertiesRector - rule #300 🎉 🎉 Rule #300 - [CodeQuality] Add CompleteDynamicPropertiesRector May 26, 2019
@TomasVotruba TomasVotruba merged commit d62174b into master May 26, 2019
@TomasVotruba TomasVotruba deleted the php-dynamic-props branch May 26, 2019 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[PHP] Complete dynamically defined properties

1 participant