[PHPUnit] Create AbstractPHPUnitRector#300
Merged
TomasVotruba merged 6 commits intomasterfrom Jan 23, 2018
Merged
Conversation
carusogabriel
force-pushed
the
phpunit-rectors
branch
from
2271824 to
ca62820
Compare
carusogabriel
changed the title
Member
|
Like it overall! Just one comment to add Have you tested that on real project? Does it pass? |
TomasVotruba
requested changes
Jan 23, 2018
| { | ||
| $className = $node->getAttribute(Attribute::CLASS_NAME); | ||
|
|
||
| return Strings::endsWith((string) $className, 'Test'); |
Member
There was a problem hiding this comment.
Could you add comment there, that this is only approximate assumption?
It might be important in some edge cases, where these Rectorswould fail, so it's easier to debug.
Member
There was a problem hiding this comment.
Also the note that from PR would be great: https://phpunit.de/getting-started-with-phpunit.html
Contributor
Author
|
@TomasVotruba |
Member
|
Awesome, thanks 👍 |
TomasVotruba
added a commit
that referenced
this pull request
May 26, 2019
TomasVotruba
added a commit
that referenced
this pull request
Jun 26, 2021
rectorphp/rector-src@04981ba Rename ReflectionAstResolver to simple AstResolver (#300)
echo511
pushed a commit
to echo511/rector
that referenced
this pull request
Sep 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves some problems with PHPUnit Rectors:
BaseTestCaseclass, not PHPUnit's;Test, as it is the standard in PHPUnit. In the feature, we can remove this check, looking up just for the assertions, but only when improving the speed of Rector.After that, a bug arises calling
toStringin FuncCall that are actually variables:$method($argument), also fixed with this PR.