Merged
Conversation
Member
Author
|
Cc @@stloyd |
stloyd
reviewed
Jul 3, 2019
|
|
||
| private function shouldSkip(): bool | ||
| { | ||
| if ($this->isAtLeastPhpVersion('7.3')) { |
Contributor
There was a problem hiding this comment.
Shouldn't those check be opposite?
You can have polyfill with that method on even PHP 7.0, so first it should check for polyfill/method availability, then check PHP version, no?
Member
Author
There was a problem hiding this comment.
You're right of course!
Care for you PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1650