[Bugfix] IsCountableRector & IsIterableRector should first check method availability#1677
Merged
TomasVotruba merged 2 commits intorectorphp:masterfrom Jul 4, 2019
Merged
[Bugfix] IsCountableRector & IsIterableRector should first check method availability#1677TomasVotruba merged 2 commits intorectorphp:masterfrom
IsCountableRector & IsIterableRector should first check method availability#1677TomasVotruba merged 2 commits intorectorphp:masterfrom
Conversation
Member
|
CI is failing. Could you look at it? |
stloyd
commented
Jul 3, 2019
TomasVotruba
reviewed
Jul 3, 2019
Member
|
Thanks for quick response! There is one more issue on Travis with lowest dependencies: https://travis-ci.org/rectorphp/rector/jobs/553693071#L658 This is how you replicate on local machine: composer update --prefer-lowest
vendor/bin/phpunit |
…method availability
Member
|
Thank you 👍 |
TomasVotruba
added a commit
that referenced
this pull request
Jan 14, 2022
rectorphp/rector-src@a17759c [Php74] Mirror comment on Closure return to ArrowFunction expr on ClosureToArrowFunctionRector (#1677)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User can have polyfill with that method on even PHP 7.0, so first it should check for polyfill/method availability, then check PHP version.