Merged
Conversation
TomasVotruba
force-pushed
the
invalid-config
branch
from
d5d0974 to
afef0e5
Compare
TomasVotruba
commented
Sep 26, 2019
| # class { var $value; } → class { public $value; } | ||
| Rector\Php52\Rector\Property\VarToPublicPropertyRector: ~pu | ||
|
|
||
| Rector\Php52\Rector\Property\VarToPublicPropertyRector: ~ |
Member
Author
There was a problem hiding this comment.
@gnutix This was the issue :D slow PHPStorm + my hasty hands to run pu as phpunit
Contributor
There was a problem hiding this comment.
Ahahah that's a nice one xD Too bad it's still "valid YAML"... can't catch this with a linter.
I confirm that disabling the celebrity import works.
Member
Author
There was a problem hiding this comment.
Indeed :D
But now it's not valid for the configuration - it will throw exception here now: https://github.com/rectorphp/rector/pull/2043/files#diff-4b356c6550ab7f23c4b4d17595032977R69
…valid configuration
TomasVotruba
force-pushed
the
invalid-config
branch
from
afef0e5 to
fcb8657
Compare
TomasVotruba
added a commit
that referenced
this pull request
Apr 10, 2022
rectorphp/rector-src@b9a912b [DX] RectorConfig - add ruleWithConfiguration() and other methods (#2043)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will prevent issues like: #2041
Closes #2042