[CI] run all sets check

.travis.yml

@@ -48,6 +48,7 @@ script:
           bin/rector process src --set symfony40 --dry-run
           composer docs
           php bin/check_services_in_yaml_configs.php
+          php bin/run_all_sets.php
       fi
 
     # Eat your own dog food

bin/run_all_sets.php

@@ -0,0 +1,52 @@
+<?php declare(strict_types=1);
+
+use Nette\Utils\Strings;
+use Rector\Set\SetProvider;
+use Symfony\Component\Process\Exception\ProcessFailedException;
+use Symfony\Component\Process\Process;
+use Symplify\PackageBuilder\Console\ShellCode;
+
+require __DIR__ . '/../vendor/autoload.php';
+
+$setProvider = new SetProvider();
+
+// any file to be tested
+$file = 'src/Rector/AbstractRector.php';
+$excludedSets = [
+    // required Kernel class to be set in parameters
+    'symfony-code-quality'
+];
+
+$errors = [];
+foreach ($setProvider->provide() as $setName) {
+    if (in_array($setName, $excludedSets, true)) {
+        continue;
+    }
+
+    $command = ['php', 'bin/rector', 'process', $file, '--set', $setName, '--dry-run'];
+
+
+    $process = new Process($command, __DIR__ . '/..');
+    echo sprintf('Set "%s" is OK' . PHP_EOL, $setName);
+
+    try {
+        $process->mustRun();
+    } catch (ProcessFailedException $processFailedException) {
+        if (! Strings::match($processFailedException->getMessage(), '#(Fatal error)|(\[ERROR\])#')) {
+            continue;
+        }
+
+        $errors[] = $processFailedException->getMessage();
+    }
+}
+
+if ($errors === []) {
+    exit(ShellCode::SUCCESS);
+}
+
+foreach ($errors as $error) {
+    echo $error;
+    echo PHP_EOL;
+}
+
+exit(ShellCode::ERROR);

config/set/celebrity/celebrity.yaml

@@ -32,8 +32,7 @@ services:
     Rector\Celebrity\Rector\FuncCall\SetTypeToCastRector: ~
 
     # class { var $value; } → class { public $value; }
-    Rector\Php52\Rector\Property\VarToPublicPropertyRector: ~pu
-
+    Rector\Php52\Rector\Property\VarToPublicPropertyRector: ~
 
     #  false or true → false || true
     #  false and true → false && true

config/set/easy-corp/easy-admin-bundle20.yaml

@@ -2,7 +2,8 @@
 services:
     # first replace ->get("...") by constructor injection in every child of "EasyCorp\Bundle\EasyAdminBundle\AdminController"
     Rector\Symfony\Rector\FrameworkBundle\GetToConstructorInjectionRector:
-        EasyCorp\Bundle\EasyAdminBundle\AdminController: ~
+        $getMethodAwareTypes:
+            - 'EasyCorp\Bundle\EasyAdminBundle\AdminController'
 
     # then rename the "EasyCorp\Bundle\EasyAdminBundle\AdminController" class
     Rector\Renaming\Rector\Class_\RenameClassRector:

config/set/framework-migration/nette-to-symfony.yaml

@@ -38,8 +38,9 @@ services:
             addConfig: load
 
     Rector\Rector\Interface_\RemoveInterfacesRector:
-        # Removes "implements IPresenter"
-        - Nette\Application\IPresenter
+        $interfacesToRemove:
+            # Removes "implements IPresenter"
+            - Nette\Application\IPresenter
 
     Rector\Renaming\Rector\Constant\RenameClassConstantRector:
         Nette\Http\*Response:

packages/NetteTesterToPHPUnit/src/Rector/RenameTesterTestToPHPUnitToTestFileRector.php

@@ -18,8 +18,11 @@ public function getDefinition(): RectorDefinition
     public function refactor(SmartFileInfo $smartFileInfo): void
     {
         $oldRealPath = $smartFileInfo->getRealPath();
-        $newRealPath = $this->createNewRealPath($oldRealPath);
+        if (! Strings::endsWith($oldRealPath, '*.phpt')) {
+            return;
+        }
 
+        $newRealPath = $this->createNewRealPath($oldRealPath);
         if ($newRealPath === $oldRealPath) {
             return;
         }

packages/NodeTypeResolver/src/NodeTypeResolver.php

@@ -128,6 +128,8 @@ public function __construct(
      */
     public function isObjectType(Node $node, $requiredType): bool
     {
+        $this->ensureRequiredTypeIsStringOrObjectType($requiredType, 'isObjectType');
+
         if (is_string($requiredType)) {
             if (Strings::contains($requiredType, '*')) {
                 return $this->isFnMatch($node, $requiredType);
@@ -699,4 +701,27 @@ private function unionWithParentClassesInterfacesAndUsedTraits(Type $type): Type
 
         return $type;
     }
+
+    /**
+     * @param mixed $requiredType
+     */
+    private function ensureRequiredTypeIsStringOrObjectType($requiredType, string $location): void
+    {
+        if (is_string($requiredType)) {
+            return;
+        }
+
+        if ($requiredType instanceof ObjectType) {
+            return;
+        }
+
+        $reportedType = is_object($requiredType) ? get_class($requiredType) : $requiredType;
+
+        throw new ShouldNotHappenException(sprintf(
+            'Value passed to "%s()" must be string or "%s". "%s" given',
+            $location,
+            ObjectType::class,
+            $reportedType
+        ));
+    }
 }

src/Console/Command/SetsCommand.php

@@ -4,11 +4,11 @@
 
 use Nette\Utils\Strings;
 use Rector\Console\Shell;
+use Rector\Set\SetProvider;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Style\SymfonyStyle;
-use Symfony\Component\Finder\Finder;
 use Symplify\PackageBuilder\Console\Command\CommandNaming;
 
 final class SetsCommand extends AbstractCommand
@@ -18,9 +18,15 @@ final class SetsCommand extends AbstractCommand
      */
     private $symfonyStyle;
 
-    public function __construct(SymfonyStyle $symfonyStyle)
+    /**
+     * @var SetProvider
+     */
+    private $setProvider;
+
+    public function __construct(SymfonyStyle $symfonyStyle, SetProvider $setProvider)
     {
         $this->symfonyStyle = $symfonyStyle;
+        $this->setProvider = $setProvider;
 
         parent::__construct();
     }
@@ -34,7 +40,7 @@ protected function configure(): void
 
     protected function execute(InputInterface $input, OutputInterface $output): int
     {
-        $sets = $this->getAvailbleSets();
+        $sets = $this->setProvider->provide();
 
         if ($input->getArgument('name')) {
             $sets = $this->filterSetsByName($input, $sets);
@@ -46,24 +52,6 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         return Shell::CODE_SUCCESS;
     }
 
-    /**
-     * @return string[]
-     */
-    private function getAvailbleSets(): array
-    {
-        $finder = Finder::create()->files()
-            ->in(__DIR__ . '/../../../config/set');
-
-        $sets = [];
-        foreach ($finder->getIterator() as $fileInfo) {
-            $sets[] = $fileInfo->getBasename('.' . $fileInfo->getExtension());
-        }
-
-        sort($sets);
-
-        return array_unique($sets);
-    }
-
     /**
      * @param string[] $sets
      * @return string[]

src/DependencyInjection/Loader/RectorServiceParametersShifter.php

@@ -4,6 +4,7 @@
 
 use Nette\Utils\Strings;
 use Rector\Exception\Configuration\InvalidConfigurationException;
+use Rector\Exception\ShouldNotHappenException;
 use ReflectionClass;
 use Symfony\Component\DependencyInjection\Loader\YamlFileLoader;
 use Symfony\Component\Yaml\Yaml;
@@ -43,13 +44,13 @@ public function __construct()
      * @param mixed[] $configuration
      * @return mixed[]
      */
-    public function process(array $configuration): array
+    public function process(array $configuration, string $file): array
     {
         if (! isset($configuration[self::SERVICES_KEY]) || ! is_array($configuration[self::SERVICES_KEY])) {
             return $configuration;
         }
 
-        $configuration[self::SERVICES_KEY] = $this->processServices($configuration[self::SERVICES_KEY]);
+        $configuration[self::SERVICES_KEY] = $this->processServices($configuration[self::SERVICES_KEY], $file);
 
         return $configuration;
     }
@@ -58,13 +59,21 @@ public function process(array $configuration): array
      * @param mixed[] $services
      * @return mixed[]
      */
-    private function processServices(array $services): array
+    private function processServices(array $services, string $file): array
     {
         foreach ($services as $serviceName => $serviceDefinition) {
             if (! $this->isRectorClass($serviceName) || empty($serviceDefinition)) {
                 continue;
             }
 
+            if (! is_array($serviceDefinition)) {
+                throw new ShouldNotHappenException(sprintf(
+                    'Rector rule "%s" has invalid configuration in "%s". Fix it to an array',
+                    $serviceName,
+                    $file
+                ));
+            }
+
             $nonReservedNonVariables = $this->resolveRectorConfiguration($serviceDefinition);
 
             // nothing to change

src/DependencyInjection/Loader/TolerantRectorYamlFileLoader.php

@@ -47,7 +47,7 @@ protected function loadFile($file)
 
         $this->classExistenceValidator->ensureClassesAreValid($configuration, $file);
 
-        $configuration = $this->rectorServiceParametersShifter->process($configuration);
+        $configuration = $this->rectorServiceParametersShifter->process($configuration, $file);
 
         return $this->parameterInImportResolver->process($configuration);
     }

src/Set/SetProvider.php

@@ -0,0 +1,26 @@
+<?php declare(strict_types=1);
+
+namespace Rector\Set;
+
+use Symfony\Component\Finder\Finder;
+
+final class SetProvider
+{
+    /**
+     * @return string[]
+     */
+    public function provide(): array
+    {
+        $finder = Finder::create()->files()
+            ->in(__DIR__ . '/../../config/set');
+
+        $sets = [];
+        foreach ($finder->getIterator() as $fileInfo) {
+            $sets[] = $fileInfo->getBasename('.' . $fileInfo->getExtension());
+        }
+
+        sort($sets);
+
+        return array_unique($sets);
+    }
+}