Remove travis-CI jobs which were moved to GithubAction#2591
Merged
TomasVotruba merged 3 commits intorectorphp:masterfrom Jan 7, 2020
staabm:patch-2
Merged
Remove travis-CI jobs which were moved to GithubAction#2591TomasVotruba merged 3 commits intorectorphp:masterfrom staabm:patch-2
TomasVotruba merged 3 commits intorectorphp:masterfrom
staabm:patch-2
Conversation
staabm
commented
Jan 6, 2020
|
|
||
| on: | ||
| - push | ||
| - pull_request |
Contributor
Author
There was a problem hiding this comment.
This was the missing piece why the PR was not build...
Contributor
Author
|
You can easily see that all github actions are already finished, while travis just started a single job at that time (The job failed because master is failing because of invalid cs before this PR already) |
Lctrs
reviewed
Jan 6, 2020
Comment on lines
+3
to
+5
| on: | ||
| - push | ||
| - pull_request |
Contributor
There was a problem hiding this comment.
Should be :
on:
pull_request:
push:
branches:
- masterif you don't want the CI to run twice on PR that comes from another branch in the repo.
Contributor
Author
There was a problem hiding this comment.
Thx for the suggestion. Adjusted
Member
|
Thank you 👍 |
TomasVotruba
added a commit
that referenced
this pull request
Jun 30, 2022
rectorphp/rector-src@945fcc8 [DeadCode] Handle always terminated Switch_ on RemoveUnreachableStatementRector (#2591)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You should configure the new checks to be required in case those were required before (in github branch protection).
In case it is essentiell that the „compile phar“ travis job only runs after all (including those beeing removed with this PR) previous jobs went green/successfull we should think about the job design.. (I guess travis ci does not know about status of single github actions and vice versa)