Transition fatal-error scan to GithubAction#2592
Transition fatal-error scan to GithubAction#2592TomasVotruba merged 5 commits intorectorphp:masterfrom staabm:patch-3
Conversation
| with: | ||
| php-version: 7.3 | ||
| coverage: none # disable xdebug, pcov | ||
| - run: composer install --no-progress && bin/rector scan-fatal-errors tests/Source/FatalErrors |
There was a problem hiding this comment.
&& should never be used, it's not clear if the first fails && the second.
Could you move it to generic install section above somehow? The same way other CI's have it?
|
In case you want more jobs transitioned to GithubAction please give me a ping and I will see. I would prefer moving those which have a similar setup like the ones we already moved. |
|
Thanks! I was checking it yesterday and Github actions took around 3 mins in total. While Travis haven't started yet and takes about 5-7 extra minutes. So you can continue moving to Github 👍 |
|
Travis also takes more time because of the defined stages. Those are build sequentially |
|
I wonder, why stay with Travis at all? |
|
Ok, I see what you are after now |
rectorphp/rector-src@82b2467 [DeadCode] Handle anonymous and arrow function uses in RemoveJustPropertyFetchRector (#2592)
2 participants
#2591 Should be merged before this PR, so we can see the status of the transition job in this PR prior merging