Skip to content

Decouple PHPStanStaticTypeMapper#2660

Merged
TomasVotruba merged 3 commits intomasterfrom
static-type-mapper
Jan 14, 2020
Merged

Decouple PHPStanStaticTypeMapper#2660
TomasVotruba merged 3 commits intomasterfrom
static-type-mapper

Conversation

@TomasVotruba
Copy link
Copy Markdown
Member

@TomasVotruba TomasVotruba commented Jan 14, 2020

Follow up to design cleanup in #2649

Moving from god classes to collector pattern and CI checked compatbility with PHPStan types

Closes #2614

Todo

@TomasVotruba TomasVotruba marked this pull request as ready for review January 14, 2020 16:50
@TomasVotruba TomasVotruba merged commit 68f0604 into master Jan 14, 2020
@TomasVotruba TomasVotruba deleted the static-type-mapper branch January 17, 2020 17:49
TomasVotruba added a commit that referenced this pull request Jul 15, 2022
rectorphp/rector-src@db7012e [Php80] Add implements interface support on single file on AddParamBasedOnParentClassMethodRector (#2660)
TomasVotruba added a commit that referenced this pull request Jul 15, 2022
rectorphp/rector-src@db7012e [Php80] Add implements interface support on single file on AddParamBasedOnParentClassMethodRector (#2660)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NotImplementedException due to: "Rector\NodeTypeResolver\StaticTypeMapper::mapPHPStanTypeToPhpParserNode for PHPStan\Type\IntersectionType"

1 participant