Skip to content

Fix sync releases with rector-prefixed#2686

Merged
TomasVotruba merged 1 commit intorectorphp:masterfrom
Lctrs:fix-sync-prefixed
Jan 17, 2020
Merged

Fix sync releases with rector-prefixed#2686
TomasVotruba merged 1 commit intorectorphp:masterfrom
Lctrs:fix-sync-prefixed

Conversation

@Lctrs
Copy link
Copy Markdown
Contributor

@Lctrs Lctrs commented Jan 17, 2020

@Lctrs
Copy link
Copy Markdown
Contributor Author

Lctrs commented Jan 17, 2020

@TomasVotruba I tested it on my fork. Works well.

@Lctrs
Copy link
Copy Markdown
Contributor Author

Lctrs commented Jan 17, 2020

Note that we could also use the release event to trigger an auto release in rector-prefixed only when a new release has been published in this repo.

@TomasVotruba
Copy link
Copy Markdown
Member

No change should be needed from at rectorphp/rector-prefixed

@Lctrs
Copy link
Copy Markdown
Contributor Author

Lctrs commented Jan 17, 2020

The PR in rector-prefixed is not needed stricto sensu. It's just here to ease maintenance by automating the release. We could also just create a draft release there that you can manually publish if you want more control.

@TomasVotruba
Copy link
Copy Markdown
Member

The release of both packages worked from here, just the tag was missed when migrated from Travis to Github Actinons

@TomasVotruba
Copy link
Copy Markdown
Member

Let's give it a try

@TomasVotruba TomasVotruba merged commit d60a4e6 into rectorphp:master Jan 17, 2020
@Lctrs Lctrs deleted the fix-sync-prefixed branch January 17, 2020 12:02
TomasVotruba added a commit that referenced this pull request Jul 19, 2022
rectorphp/rector-src@b492d20 [DX] Cleanup, Remove RepeatedLiteralToClassConstantRector, as very narrow use case; use rather phpstan + Remove ChangeLocalPropertyToVariableRector, as buggy and unreliable; better use PHPStan (#2686)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants