github-action: Annotate Github Pull Requests based on a Checkstyle X…#2756
Merged
TomasVotruba merged 8 commits intorectorphp:masterfrom Feb 5, 2020
staabm:patch-3
Merged
github-action: Annotate Github Pull Requests based on a Checkstyle X…#2756TomasVotruba merged 8 commits intorectorphp:masterfrom staabm:patch-3
TomasVotruba merged 8 commits intorectorphp:masterfrom
staabm:patch-3
Conversation
Contributor
Author
|
Does any other tool within the GithubAction jobs support checkstyle? |
staabm
changed the title
Because this is proxied thru composer we need to separate the arguments
staabm
commented
Jan 25, 2020
Contributor
Author
|
this PR is ready to merge now. In case you like it, I can drop the "testing" change from https://github.com/rectorphp/rector/pull/2756/files#r370930092 In case there is something left todo - or you have open questions - feel free to ask |
Member
|
Let's give it a try 👍 |
Member
|
Ping me when it's ready |
Contributor
Author
|
ping @TomasVotruba ready to merge. in case you like it - we can use this tool for every GithubAction which is able to provide a checkstyle-formatter report. |
Member
|
Thank you! |
TomasVotruba
added a commit
that referenced
this pull request
Aug 12, 2022
rectorphp/rector-src@da9fab1 [Naming] Remove single- prefix from RenameForeachValueVariableToMatchExprVariableRector, creates weird names (#2756)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ML-report
That means you no longer search thru your GithubAction logfiles. No need to interpret messages which are formatted differently with every tool. Instead you can focus on your Pull Request, and you don't need to leave the Pull Request area.
See https://github.com/staabm/annotate-pull-request-from-checkstyle