Added phpunit problem matcher#2757
Merged
TomasVotruba merged 6 commits intorectorphp:masterfrom Jan 28, 2020
staabm:patch-4
Merged
Added phpunit problem matcher#2757TomasVotruba merged 6 commits intorectorphp:masterfrom staabm:patch-4
TomasVotruba merged 6 commits intorectorphp:masterfrom
staabm:patch-4
Conversation
Member
|
Now there are false positives. Error reported for skipped tests |
Contributor
Author
|
Reported the issue upstream in shivammathur/setup-php#163 Not sure it is fixable though |
Contributor
Author
|
After checking the phpunit sources, I wonder why we see the infos printed regarding skipped tests. These should only be printed in verbose-mode |
Contributor
Author
|
Guess I found it |
staabm
commented
Jan 26, 2020
Contributor
Author
|
We got an upstream release and things are looking better now |
Contributor
Author
|
Any feedback? |
TomasVotruba
approved these changes
Jan 28, 2020
Contributor
Author
|
Here you are! |
Member
|
Looks good! Thank you for your work 👍 |
Member
|
I'll look how this can be added for Rector |
TomasVotruba
added a commit
that referenced
this pull request
Aug 12, 2022
rectorphp/rector-src@858f055 [Core] Move Scope Resolver to ScopeAnalyzer (#2757)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #2756 this will enable reporting of phpunit test failures into the files-changed PR tab