Skip to content

Merge pull request #2775 from rectorphp/php-doc-object-attribute#2775

Merged
TomasVotruba merged 2 commits intomasterfrom
php-doc-object-attribute
Jan 31, 2020
Merged

Merge pull request #2775 from rectorphp/php-doc-object-attribute#2775
TomasVotruba merged 2 commits intomasterfrom
php-doc-object-attribute

Conversation

@TomasVotruba
Copy link
Copy Markdown
Member

@TomasVotruba TomasVotruba commented Jan 29, 2020

Main Improvements

  • doc is not created ad hoc manually on every use, but with parsing decoration - the way parent nodes and names are resolved
  • constistent API with one point of origin
  • PhpDocInfo becomes smart value object wich modifying method
  • persistence (printing PhpDocInfo back to string) if still left on the printer, so no coupling to the service layer

@TomasVotruba TomasVotruba force-pushed the php-doc-object-attribute branch 4 times, most recently from 1760869 to 385ab30 Compare January 30, 2020 20:28
@TomasVotruba TomasVotruba force-pushed the php-doc-object-attribute branch 7 times, most recently from be49791 to 5d04362 Compare January 31, 2020 06:52
@TomasVotruba TomasVotruba force-pushed the php-doc-object-attribute branch from 5d04362 to f0de672 Compare January 31, 2020 06:53
@TomasVotruba TomasVotruba merged commit d1757f2 into master Jan 31, 2020
@TomasVotruba TomasVotruba changed the title [DX] Reducing technical debt of DocBlockManipulator with 705 lines Merge pull request #2775 from rectorphp/php-doc-object-attribute Jan 31, 2020
@TomasVotruba TomasVotruba deleted the php-doc-object-attribute branch January 31, 2020 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant