Skip to content

Fix comment removing#3311

Merged
TomasVotruba merged 1 commit intomasterfrom
two-docblocks
May 4, 2020
Merged

Fix comment removing#3311
TomasVotruba merged 1 commit intomasterfrom
two-docblocks

Conversation

@TomasVotruba
Copy link
Copy Markdown
Member

@TomasVotruba TomasVotruba commented May 4, 2020

Replaces #3250

Fixes #3222

Releated to switch of docblocks to PHPDocInfo - #2775

@TomasVotruba TomasVotruba marked this pull request as draft May 4, 2020 21:47
@TomasVotruba TomasVotruba force-pushed the two-docblocks branch 2 times, most recently from 86cf529 to 63cca06 Compare May 4, 2020 22:06
@TomasVotruba TomasVotruba marked this pull request as ready for review May 4, 2020 22:07
@TomasVotruba TomasVotruba changed the title Add test case for #3222 Fix comment removing May 4, 2020
@TomasVotruba TomasVotruba force-pushed the two-docblocks branch 3 times, most recently from d45f46c to 0f3d8c7 Compare May 4, 2020 22:12
@TomasVotruba
Copy link
Copy Markdown
Member Author

TomasVotruba commented May 4, 2020

@shaal This might require more testing, but it's a good start.

If you find another failing piece of code, don't create an issues, but send as a it new file for test, like this one: https://github.com/rectorphp/rector/pull/3311/files#diff-f49c98006c140983dfee6229f4f15240

@TomasVotruba TomasVotruba merged commit c29e027 into master May 4, 2020
@kodiakhq kodiakhq bot deleted the two-docblocks branch May 4, 2020 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Additional (code standard?) rules are running by default

1 participant