AssertTrueFalseToSpecificMethodRector: add broken test ('Pick more specific node than PhpParser\Node\Expr\StaticCall')#2990
Merged
TomasVotruba merged 2 commits intorectorphp:masterfrom Mar 3, 2020
Conversation
…ecific node than PhpParser\Node\Expr\StaticCall').
Member
|
If you look at stack trace, you see the problem is here: The value must be |
Contributor
Author
|
I did not understood your comment. But looking at the code of this Rector, it makes no sense to apply it on StaticCall methods, as it seems to be meant to replace PHP functions calls to PHPUnit specific assert methods. So I fixed it that way. |
TomasVotruba
approved these changes
Mar 3, 2020
TomasVotruba
deleted the
AssertTrueFalseToSpecificMethodRector/add-broken-test-static-call
branch
TomasVotruba
reviewed
Mar 3, 2020
|
|
||
| $firstArgumentValue = $node->args[0]->value; | ||
| if (! $this->isNames($firstArgumentValue, array_keys(self::OLD_TO_NEW_METHODS))) { | ||
| if ($firstArgumentValue instanceof StaticCall || |
Member
There was a problem hiding this comment.
What about ! FuncCall and early return null;?
TomasVotruba
added a commit
that referenced
this pull request
Oct 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #2953.