Fix various static calls errors in PHPUnit Rectors.#2997
Merged
TomasVotruba merged 1 commit intorectorphp:masterfrom Mar 3, 2020
Merged
Fix various static calls errors in PHPUnit Rectors.#2997TomasVotruba merged 1 commit intorectorphp:masterfrom
TomasVotruba merged 1 commit intorectorphp:masterfrom
Conversation
TomasVotruba
reviewed
Mar 3, 2020
| } | ||
|
|
||
| $firstArgumentValue = $node->args[0]->value; | ||
| if ($firstArgumentValue instanceof StaticCall) { |
Member
There was a problem hiding this comment.
Again, should be ! $firstArgumentValue instanceof FuncCall
Always go for stricter condition.
Contributor
Author
There was a problem hiding this comment.
I tried and it broke the tests.
Contributor
Author
There was a problem hiding this comment.
I don't remember by heart and I don't have more time to dedicate to this.
Feel free to try triggering the failing tests yourself (by applying the change you're suggesting) and you can then decide if you want to write this any differently.
Member
There was a problem hiding this comment.
Alright. Let's give it a go now, and wait for more issues
Comment on lines
+85
to
88
| if ($firstArgumentValue instanceof StaticCall) { | ||
| return null; | ||
| } | ||
| if (! $this->isName($firstArgumentValue, 'property_exists')) { |
Comment on lines
+76
to
+78
| if ($firstArgumentValue instanceof StaticCall) { | ||
| return null; | ||
| } |
Member
|
Good job with right places to fix this 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes remaining Rectors of #2953 and #2990 (PS: I tried
! $firstArgumentValue instanceof FuncCallbut it broke many tests, so I kept$firstArgumentValue instanceof StaticCalland put it in its ownif)