AnnotateThrowables: support analysis of called functions and methods#2998
Merged
TomasVotruba merged 12 commits intorectorphp:masterfrom Mar 6, 2020
Aerendir:support-throwing-functions
Merged
AnnotateThrowables: support analysis of called functions and methods#2998TomasVotruba merged 12 commits intorectorphp:masterfrom Aerendir:support-throwing-functions
TomasVotruba merged 12 commits intorectorphp:masterfrom
Aerendir:support-throwing-functions
Conversation
Aerendir
changed the title
Contributor
Author
|
@TomasVotruba , Ready to be merged! Before merging, please check this code: |
Contributor
Author
|
Do not merge: some work still required... I'm testing the Rector in an app and it causes exceptions... |
Member
|
I'm waiting, no troubles |
TomasVotruba
reviewed
Mar 3, 2020
Contributor
Author
|
Needs refactoring and checks to pass. |
Contributor
Author
|
@TomasVotruba , completely refactored and ready to be merged! 💪 |
TomasVotruba
reviewed
Mar 4, 2020
TomasVotruba
reviewed
Mar 4, 2020
Member
TomasVotruba
left a comment
TomasVotruba
left a comment
There was a problem hiding this comment.
I've left few notes to refactor for less class complexity.
The Rector rule is getting huge. Healthy maximum limit is around 250 lines. Anything higher usually lead to long tracing of bug later.
Service decoupling should allow that.
Aerendir
changed the title
TomasVotruba
reviewed
Mar 5, 2020
TomasVotruba
reviewed
Mar 5, 2020
TomasVotruba
reviewed
Mar 5, 2020
Contributor
Author
|
I did a very deep refactoring. I created some classes and put them where and gave them a name I think may be appropriate . Please, review the code as I don't know if you prefer different namings/namespacings/etc... |
Member
|
Looks good 👍 |
Member
|
Thank you 👏 |
TomasVotruba
added a commit
that referenced
this pull request
Oct 17, 2022
rectorphp/rector-src@71b1142 [CodeQuality] Skip different value left and right on SimplifyEmptyArrayCheckRector (#2998)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was #2928
Support
$varName->method();$methodParam->method();$this->method();