Skip to content

[CodingStyle] Drop AnnotateThrowablesRector to narrow code scope, designed for custom community rule#5528

Merged
TomasVotruba merged 1 commit intomasterfrom
drop-throws
Feb 13, 2021
Merged

[CodingStyle] Drop AnnotateThrowablesRector to narrow code scope, designed for custom community rule#5528
TomasVotruba merged 1 commit intomasterfrom
drop-throws

Conversation

@TomasVotruba
Copy link
Copy Markdown
Member

@TomasVotruba TomasVotruba commented Feb 13, 2021

Hi @Aerendir ,

as this PR is related to your contribution, #2998, we though we should let you know about it.

We're trying to deliver Rector to the wider community, with lower PHP as PHP 5.6 and prefixed dependencies.
Current Rector code-base is now bloated with rule, that should have been implemented by community itself. This drags development itself down, we don't have coding power to maintain all this while developing new features and keeping up to date with legacy code requirements.

To this burden gropus belonged 3 Phalcon rules (#5313), Sonarcube (#5215) or events (#4865).

Saying that, we're dropping few rules, to be able to improve code base. We pick rules that can be adapated by community, like this. We'd be happy if this code is moved, maintained and used in external package as the idea itself is valid 👍

For inspiration, sSimilar community work is done in:

We know it's not a convenient, but we hope you take it well for Rector be able to grow 🙂

Let us know if you need any help with migration. We'll be happy to help 👍

@TomasVotruba TomasVotruba changed the title drop throws [CodingStyle] Drop AnnotateThrowablesRector to narrow code scope, designed for custom community rule Feb 13, 2021
@Aerendir
Copy link
Copy Markdown
Contributor

Hi @TomasVotruba , thank you for the message :)

I'm not currently using the rule anymore.

It had a lot of improvements to be done, and caused a lot of issues as it requires multiple runs to annotate properly the methods.

In this moment I think that, also if the idea is good, the implementation effort is really too much compared to the benefit :(

@TomasVotruba
Copy link
Copy Markdown
Member Author

Thank you for reaching out and for the feedback 👍

@TomasVotruba TomasVotruba merged commit 6ce792c into master Feb 13, 2021
@TomasVotruba TomasVotruba deleted the drop-throws branch February 13, 2021 14:19
TomasVotruba added a commit that referenced this pull request Jan 30, 2024
rectorphp/rector-src@6046c24 [CodingStyle] Return null on no change on StrictArraySearchRector (#5528)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants