Make sure doctrine alias rector works in symfony controllers#3146
Merged
TomasVotruba merged 1 commit intorectorphp:masterfrom Apr 7, 2020
acrobat:fix-doctrine-alias-rector
Merged
Make sure doctrine alias rector works in symfony controllers#3146TomasVotruba merged 1 commit intorectorphp:masterfrom acrobat:fix-doctrine-alias-rector
TomasVotruba merged 1 commit intorectorphp:masterfrom
acrobat:fix-doctrine-alias-rector
Conversation
Member
|
Thank you, great job with the test 👍 |
TomasVotruba
approved these changes
Apr 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While using this rector on a project, I noticed it didn't work on symfony controllers. Because the
$this->getDoctrine()->getManager()returns an instance ofDoctrine\Persistence\ObjectManager(or the deprecated interfaceDoctrine\Common\Persistence\ObjectManager). So I've debugged and adjusted the check so it would also work in symfony controllers.The only strange thing is that the original example (test fixture) does work in the test suite with the old code, but it didn't work in the project I was debugging 🤷♂