Add extra allowed interface to EntityAliasToClassConstantReferenceRector#3155
Merged
TomasVotruba merged 1 commit intorectorphp:masterfrom Apr 10, 2020
acrobat:add-extra-doctrine-alias-class
Merged
Add extra allowed interface to EntityAliasToClassConstantReferenceRector#3155TomasVotruba merged 1 commit intorectorphp:masterfrom acrobat:add-extra-doctrine-alias-class
TomasVotruba merged 1 commit intorectorphp:masterfrom
acrobat:add-extra-doctrine-alias-class
Conversation
Member
|
Thank you very much |
TomasVotruba
added a commit
that referenced
this pull request
Dec 5, 2022
rectorphp/rector-src@3f1a285 [Core] Fix crash indentation on indent(\t, 1) config (#3155)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an extension to the changes in #3146. I've discovered some other usages which were not covered by this rector. So these extra interfaces will allow to fix these cases also.
This is also possible as the manager registry will select to correct manager based on the provided entity.
https://github.com/doctrine/persistence/blob/fdaaa50cb23760c9da2d6dcab9f10caa34d92b61/lib/Doctrine/Persistence/AbstractManagerRegistry.php#L226-L233