Merged
Conversation
TomasVotruba
force-pushed
the
tag-value-node-2
branch
3 times, most recently
from
627ea65 to
0624c81
Compare
TomasVotruba
force-pushed
the
tag-value-node-2
branch
from
0624c81 to
d818fe2
Compare
TomasVotruba
force-pushed
the
tag-value-node-2
branch
from
55c70d8 to
1d6319f
Compare
| } | ||
|
|
||
| if (is_object($annotationOrItems)) { | ||
| return get_object_vars($annotationOrItems); |
Contributor
There was a problem hiding this comment.
@TomasVotruba For some reason, this breaks Rector in my application. A Symfony\Component\Routing\Annotation\Route object returns [] in my case.
Contributor
There was a problem hiding this comment.
I'll try to find out why it fails in my application while the tests are OK, but it's hard to keep up with your development speed at this moment.
Member
Author
There was a problem hiding this comment.
Thanks for such a fast testing, wow!
That's caused by Route annotation having private properties (made fake public in tests here for now) and get_object_vars() works only on public ones.
Do you have idea how to get into private properties of an object? Effectively.
TomasVotruba
added a commit
that referenced
this pull request
Jan 13, 2023
rectorphp/rector-src@774de56 Fix AddMethodCallBasedStrictParamTypeRector for invalid generics type (#3281)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.