Add resolving for private properties of annotation object#3285
Merged
TomasVotruba merged 6 commits intomasterfrom Apr 30, 2020
Merged
Add resolving for private properties of annotation object#3285TomasVotruba merged 6 commits intomasterfrom
TomasVotruba merged 6 commits intomasterfrom
Conversation
TomasVotruba
force-pushed
the
tag-value-node-5
branch
2 times, most recently
from
d3b0d13 to
28b54a5
Compare
Contributor
|
Have you looked at Symfony's PropertyAccess Component? |
TomasVotruba
force-pushed
the
tag-value-node-5
branch
from
28b54a5 to
b360e7c
Compare
TomasVotruba
force-pushed
the
tag-value-node-5
branch
from
b360e7c to
2e8138f
Compare
Member
Author
|
Yes. It just needed reflection, so I picked this https://ocramius.github.io/blog/fast-php-object-to-array-conversion/ There is some weird bug with class reference replacing only in @route :/ not sure why. |
TomasVotruba
changed the title
Member
Author
|
Apperently you cannot set value to private property :D It's ready to merge. |
TomasVotruba
force-pushed
the
tag-value-node-5
branch
from
78fd782 to
eb32ae4
Compare
Member
Author
|
Merging so you can test it out in the wild. |
TomasVotruba
added a commit
that referenced
this pull request
Jan 14, 2023
rectorphp/rector-src@4b6a559 Clean up mix HTML+PHP first stmt check (#3285)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #3281 (comment)