Skip to content

Add Drupal logo + link to Drupal Rector rules to README.md#3410

Merged
TomasVotruba merged 5 commits intorectorphp:masterfrom
shaal:add-drupal-logo
May 25, 2020
Merged

Add Drupal logo + link to Drupal Rector rules to README.md#3410
TomasVotruba merged 5 commits intorectorphp:masterfrom
shaal:add-drupal-logo

Conversation

@shaal
Copy link
Copy Markdown
Contributor

@shaal shaal commented May 24, 2020

Drupal has been using Rector to successfully upgrade massive amount of Drupal modules, including a bot that apply Rector rules and create patches for all available projects.

We'd like to add Drupal's logo (and a link to Drupal Rector rules) to Rector's README file.

Preview screenshot:
image

@TomasVotruba
Copy link
Copy Markdown
Member

You can move the logo on first line (between Laravel and Symfony?), as the Drupal Rector set is very rich and activelly developed.

@shaal
Copy link
Copy Markdown
Contributor Author

shaal commented May 25, 2020

I moved Twig logo to first line, to optimize space (otherwise 3 lines are needed to display the logos).

Is that ok? Or should I keep the order of logos the same way you described it?

@TomasVotruba
Copy link
Copy Markdown
Member

This look great! Thanks for the screenshot, it's easy to check it for me

@TomasVotruba TomasVotruba merged commit 8423563 into rectorphp:master May 25, 2020
@shaal
Copy link
Copy Markdown
Contributor Author

shaal commented May 25, 2020

Thank you!

TomasVotruba added a commit that referenced this pull request Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants