fix(fab): fixing css issues#427
Merged
christoph-jerolimov merged 19 commits intoredhat-developer:mainfrom Mar 17, 2025
Merged
Conversation
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
its-mitesh-kumar
requested review from
christoph-jerolimov,
ciiay,
debsmita1,
divyanshiGupta and
gashcrumb
as code owners
Changed Packages
|
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
christoph-jerolimov
requested changes
Feb 17, 2025
Member
christoph-jerolimov
left a comment
christoph-jerolimov
left a comment
There was a problem hiding this comment.
Hi @its-mitesh-kumar, can you please add screenshots before and after to your PR.
debsmita1
requested changes
Feb 19, 2025
Member
debsmita1
left a comment
debsmita1
left a comment
There was a problem hiding this comment.
Fab with text labels are appearing like this
updated the FAB menu actions
Revert "updated the FAB menu actions"
…bal-fab Revert "Revert "updated the FAB menu actions""
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
Member
Author
|
@ShiranHi @debsmita1 does ux look fine to you . screen-recording-2025-02-25-at-125803-am_ZGkdaWoL.mp4 |
logonoff
reviewed
Feb 25, 2025
fix slide transition
Member
|
As discussed on a call, my commit cc90881 has some changes where I have tried Slide with Fade MUI components |
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
Member
|
Hey @debsmita1, can you please take a new look and check with @invincibleJai if this is a 1.5.x or 1.6.0 change? Thanks. |
debsmita1
requested changes
Mar 10, 2025
Member
debsmita1
left a comment
debsmita1
left a comment
There was a problem hiding this comment.
It looks much better now
Could you work on adding some delay to transition ?
Comment on lines
+131
to
+132
| color: iconColor ? iconColor : '#1f1f1f', | ||
| backgroundColor: !actionButton.color && !className ? 'white' : '', |
Member
There was a problem hiding this comment.
Can you undo this change and test ?
I tried it myself and it looks like this change is not needed
Member
Author
|
@ShiranHi , Now transition looks much smooth , can you review and add lgtm FAB_Final.mov |
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
debsmita1
requested changes
Mar 11, 2025
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
…ng-action-button/src/components/FABWithSubmenu.tsx Co-authored-by: Debsmita Santra <debsmita.santra@gmail.com>
debsmita1
requested changes
Mar 13, 2025
Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
|
debsmita1
approved these changes
Mar 17, 2025
Member
debsmita1
left a comment
debsmita1
left a comment
There was a problem hiding this comment.
/lgtm
Thank you @its-mitesh-kumar !
christoph-jerolimov
approved these changes
Mar 17, 2025
ishanjogi89
added a commit
to ishanjogi89/rhdh-plugins
that referenced
this pull request
Mar 18, 2025
…nto FLPATH-2143 * 'main' of https://github.com/ijogi-redhat/rhdh-plugins: chore: update code owners (redhat-developer#505) chore(marketplace): add package examples and link them from plugins (redhat-developer#503) Version Packages (redhat-developer#439) Version Packages (redhat-developer#437) feat(global-header): changing create to self-service (redhat-developer#495) fix(fab): fixing css issues (redhat-developer#427) Version Packages (redhat-developer#504) feat(marketplace): add monaco editor (redhat-developer#500) Version Packages (redhat-developer#502) fix(marketplace): align with UXD: add grey placeholder if icon is missing and placeholder when there is no description (redhat-developer#498) feat(adoption-insights): add frontend plugin for adoption insights (redhat-developer#464) fix(adoption-insights): remove unwanted columns and add techdocs type (redhat-developer#497) fix(adoption-insights): add redirection links and cast count as integers (redhat-developer#496) fix(adoption-insights): camel case column names to lower case (redhat-developer#494) Version Packages (redhat-developer#492) fix(lightspeed): remove resets from PF CSS import (redhat-developer#469) feat(adoption-insights): add grouping configuration in insights endpoints (redhat-developer#488)
elai-shalev
pushed a commit
to elai-shalev/rhdh-plugins
that referenced
this pull request
Jan 21, 2026
* fixing css issues Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com> * adding changeset Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com> * updated the FAB menu actions * Revert "updated the FAB menu actions" * Revert "Revert "updated the FAB menu actions"" * fix/fab: adding transiotn , removing text tranform Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com> * fix slide transition * fix/fab: buttons should appear from button Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com> * making transition faster Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com> * fixing sonar cloud issues Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com> * moving iconcolor to fab Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com> * updating api report Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com> * Update workspaces/global-floating-action-button/plugins/global-floating-action-button/src/components/FABWithSubmenu.tsx Co-authored-by: Debsmita Santra <debsmita.santra@gmail.com> * buttons background white Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com> --------- Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com> Co-authored-by: debsmita1 <debsmita.santra@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upload.Fab.mov
Fixes https://issues.redhat.com/browse/RHIDP-5482