Skip to content

fix(marketplace): align with UXD: add grey placeholder if icon is missing and placeholder when there is no description#498

Merged
christoph-jerolimov merged 4 commits intoredhat-developer:mainfrom
christoph-jerolimov:marketplace/allow-no-titles
Mar 17, 2025
Merged

fix(marketplace): align with UXD: add grey placeholder if icon is missing and placeholder when there is no description#498
christoph-jerolimov merged 4 commits intoredhat-developer:mainfrom
christoph-jerolimov:marketplace/allow-no-titles

Conversation

@christoph-jerolimov
Copy link
Copy Markdown
Member

@christoph-jerolimov christoph-jerolimov commented Mar 17, 2025

Hey, I just made a Pull Request!

  1. add namespace to all testdata to avoid conflicts
  2. make title and description optional
  3. render no description available when there is no description
  4. render a grey placeholder icon when there is no icon defined

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>
Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>
…n defined

Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>
…scription

Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>
@rhdh-gh-app
Copy link
Copy Markdown

rhdh-gh-app Bot commented Mar 17, 2025

Changed Packages

Package Name Package Path Changeset Bump Current Version
@red-hat-developer-hub/backstage-plugin-catalog-backend-module-marketplace workspaces/marketplace/plugins/catalog-backend-module-marketplace patch v0.2.2
@red-hat-developer-hub/backstage-plugin-marketplace workspaces/marketplace/plugins/marketplace patch v0.2.1

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Member

@ciiay ciiay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thank you 👏

@openshift-ci openshift-ci Bot added the lgtm label Mar 17, 2025
@christoph-jerolimov christoph-jerolimov merged commit 4f2bf81 into redhat-developer:main Mar 17, 2025
@christoph-jerolimov christoph-jerolimov deleted the marketplace/allow-no-titles branch March 17, 2025 22:28
ishanjogi89 added a commit to ishanjogi89/rhdh-plugins that referenced this pull request Mar 18, 2025
…nto FLPATH-2143

* 'main' of https://github.com/ijogi-redhat/rhdh-plugins:
  chore: update code owners (redhat-developer#505)
  chore(marketplace): add package examples and link them from plugins (redhat-developer#503)
  Version Packages (redhat-developer#439)
  Version Packages (redhat-developer#437)
  feat(global-header): changing create to self-service (redhat-developer#495)
  fix(fab): fixing css issues (redhat-developer#427)
  Version Packages (redhat-developer#504)
  feat(marketplace): add monaco editor (redhat-developer#500)
  Version Packages (redhat-developer#502)
  fix(marketplace): align with UXD: add grey placeholder if icon is missing and placeholder when there is no description (redhat-developer#498)
  feat(adoption-insights): add frontend plugin for adoption insights (redhat-developer#464)
  fix(adoption-insights): remove unwanted columns and add techdocs type (redhat-developer#497)
  fix(adoption-insights): add redirection links and cast count as integers (redhat-developer#496)
  fix(adoption-insights): camel case column names to lower case (redhat-developer#494)
  Version Packages (redhat-developer#492)
  fix(lightspeed): remove resets from PF CSS import (redhat-developer#469)
  feat(adoption-insights): add grouping configuration in insights endpoints (redhat-developer#488)
elai-shalev pushed a commit to elai-shalev/rhdh-plugins that referenced this pull request Jan 21, 2026
…sing and placeholder when there is no description (redhat-developer#498)

* chore(marketplace): add namespace to testdata

Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>

* fix(marketplace): make title and description optional

Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>

* fix(marketplace): render a grey placeholder icon when there is no icon defined

Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>

* fix(marketplace): render no description available when there is no description

Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>

---------

Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants