feat(adoption-insights): add frontend plugin for adoption insights by Eswaraiahsapram · Pull Request #464 · redhat-developer/rhdh-plugins

Eswaraiahsapram · 2025-03-04T08:12:05Z

Hey, I just made a Pull Request!

This PR introduces frontend changes for the new Adoption Insights plugin, enhancing the experience by providing key insights into adoption metrics.

Changes Implemented

✅ Added UI components to display Adoption Insights metrics.
✅ Integrated data visualization using Recharts to present trends effectively.
✅ Integrated date range using MUI x-date-pickers
✅ Added Unit tests
✅ Implemented pagination.

Screen recording

Screen.Recording.2025-03-11.at.2.45.59.PM.mov

Screenshots

✔️ Checklist

A changeset describing the change and affected packages. (more info)
Added or Updated documentation
Tests for new functionality and regression tests for bug fixes
Screenshots attached (for UI changes)

rhdh-gh-app · 2025-03-04T08:12:28Z

Changed Packages

Package Name	Package Path	Changeset Bump	Current Version
app	workspaces/adoption-insights/packages/app	none	`v0.0.0`
backend	workspaces/adoption-insights/packages/backend	none	`v0.0.0`
@red-hat-developer-hub/backstage-plugin-adoption-insights	workspaces/adoption-insights/plugins/adoption-insights	none	`v0.0.1`

ShiranHi · 2025-03-11T07:52:59Z

@Eswaraiahsapram it looks amazing!

I have a few questions:

Can we change the title from "Active Users" to "Active users"?
Can we add the "Export CSV" button to the "Active users" card?
Can we display a double dash (--) when there is no data in a cell? I noticed this is already implemented in the "Top catalog entities" card.
Can we add a clickable link to catalog entity and template names so that users are directed to the corresponding page when they click on them?
In the header dropdown labeled "All time", can we rename it to "Date range" instead of "Date Range"?
Regarding the "Date range" dropdown with the calendar view:
A. Can we reduce the title size to match the design?
B. Can we make the "Start date" field pre-selected?
C. Can we include the date format (e.g., mm/dd/yyyy) as a placeholder in the field?
D. Can we align the date picker width to match the text fields?

Eswaraiahsapram · 2025-03-11T09:22:15Z

@Eswaraiahsapram it looks amazing!

I have a few questions:

Can we change the title from "Active Users" to "Active users"?

Can we add the "Export CSV" button to the "Active users" card?

Can we display a double dash (--) when there is no data in a cell? I noticed this is already implemented in the "Top catalog entities" card.

Can we add a clickable link to catalog entity and template names so that users are directed to the corresponding page when they click on them?

In the header dropdown labeled "All time", can we rename it to "Date range" instead of "Date Range"?

Regarding the "Date range" dropdown with the calendar view:
A. Can we reduce the title size to match the design?
B. Can we make the "Start date" field pre-selected?
C. Can we include the date format (e.g., mm/dd/yyyy) as a placeholder in the field?
D. Can we align the date picker width to match the text fields?

@ShiranHi thanks for the feedback!

I forgot to update the screenshots earlier. I'm adding a new screen recording now. Please let me know if anything needs to update.

Regarding aligning the date picker width with the text fields, there are some limitations with the StaticDatePicker in MUI. However, I’ll explore possible adjustments to improve the alignment.

ShiranHi · 2025-03-11T10:09:21Z

Thanks for the video! I can now see more cards. I have a few follow-up questions:

"Top 3 templates" card: Can we reduce the padding between the columns so they are closer together?
"Active users" tooltip: Can we adjust the layout to match the design?
"Top 3 techdocs" card: The content in the Entity column should be clickable as well.
"X searches" card: The tooltip needs some adjustments to align with the design.
For the empty state, instead of "No data available" can we change it to "No results for this time range."?

rohitkrai03 · 2025-03-11T12:21:16Z

I feel we might be able put some of these into the common plugin once we have it.

karthikjeeyar

@Eswaraiahsapram This looks great 🎉, I have added few comments, PTAL.

FYI, Sonarcloud issues has to be fixed too.

karthikjeeyar

fyi, after recent changes Pie chart is not working as expected.

Eswaraiahsapram · 2025-03-14T11:26:59Z

fyi, after recent changes Pie chart is not working as expected.

@karthikjeeyar, could you please help me reproduce this issue? I haven't encountered it myself.

karthikjeeyar

Techdocs chart is not showing up if there is less than 3 data from the API response. Notice the API is returning the 2 items in response but it is not visible in the techdocs chart.

sonarqubecloud · 2025-03-17T12:41:00Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.8% Duplication on New Code

See analysis details on SonarQube Cloud

karthikjeeyar

Thanks @Eswaraiahsapram for the follow up. Changes looks good to me

/lgtm

rohitkrai03

/approve

…nto FLPATH-2143 * 'main' of https://github.com/ijogi-redhat/rhdh-plugins: chore: update code owners (redhat-developer#505) chore(marketplace): add package examples and link them from plugins (redhat-developer#503) Version Packages (redhat-developer#439) Version Packages (redhat-developer#437) feat(global-header): changing create to self-service (redhat-developer#495) fix(fab): fixing css issues (redhat-developer#427) Version Packages (redhat-developer#504) feat(marketplace): add monaco editor (redhat-developer#500) Version Packages (redhat-developer#502) fix(marketplace): align with UXD: add grey placeholder if icon is missing and placeholder when there is no description (redhat-developer#498) feat(adoption-insights): add frontend plugin for adoption insights (redhat-developer#464) fix(adoption-insights): remove unwanted columns and add techdocs type (redhat-developer#497) fix(adoption-insights): add redirection links and cast count as integers (redhat-developer#496) fix(adoption-insights): camel case column names to lower case (redhat-developer#494) Version Packages (redhat-developer#492) fix(lightspeed): remove resets from PF CSS import (redhat-developer#469) feat(adoption-insights): add grouping configuration in insights endpoints (redhat-developer#488)

…edhat-developer#464) * feat(adoption-insights): add frontend plugin for adoption insights * resolved the type issue * updated unit tests * add github backend module * remove unwanted column techdocs * remove unwanted column techdocs

Eswaraiahsapram requested review from karthikjeeyar and rohitkrai03 as code owners March 4, 2025 08:12

rohitkrai03 requested changes Mar 11, 2025

View reviewed changes

Eswaraiahsapram requested a review from rohitkrai03 March 12, 2025 22:38

karthikjeeyar requested changes Mar 13, 2025

View reviewed changes

karthikjeeyar reviewed Mar 13, 2025

View reviewed changes

Eswaraiahsapram requested a review from karthikjeeyar March 13, 2025 11:36

karthikjeeyar requested changes Mar 13, 2025

View reviewed changes

Eswaraiahsapram requested a review from karthikjeeyar March 17, 2025 01:45

Eswaraiahsapram force-pushed the feat-adoption-insights-fe branch from ea36b55 to 7093057 Compare March 17, 2025 09:09

karthikjeeyar reviewed Mar 17, 2025

View reviewed changes

Comment thread workspaces/adoption-insights/packages/app/src/App.tsx Outdated

Eswaraiahsapram added 4 commits March 17, 2025 16:49

feat(adoption-insights): add frontend plugin for adoption insights

f339235

resolved the type issue

6e14d66

updated unit tests

b8f0682

add github backend module

4223218

Eswaraiahsapram force-pushed the feat-adoption-insights-fe branch from 8a5af05 to 4223218 Compare March 17, 2025 11:55

Eswaraiahsapram requested a review from karthikjeeyar March 17, 2025 11:59

Eswaraiahsapram added 2 commits March 17, 2025 18:04

remove unwanted column techdocs

5db5d33

remove unwanted column techdocs

4bed845

karthikjeeyar approved these changes Mar 17, 2025

View reviewed changes

openshift-ci Bot assigned karthikjeeyar Mar 17, 2025

openshift-ci Bot added the lgtm label Mar 17, 2025

Eswaraiahsapram requested a review from ShiranHi March 17, 2025 13:10

rohitkrai03 approved these changes Mar 17, 2025

View reviewed changes

rohitkrai03 merged commit eda0343 into redhat-developer:main Mar 17, 2025

Conversation

Eswaraiahsapram commented Mar 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Hey, I just made a Pull Request!

Changes Implemented

Screen recording

Screenshots

✔️ Checklist

Uh oh!

rhdh-gh-app Bot commented Mar 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changed Packages

Uh oh!

ShiranHi commented Mar 11, 2025

Uh oh!

Eswaraiahsapram commented Mar 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ShiranHi commented Mar 11, 2025

Uh oh!

Uh oh!

rohitkrai03 Mar 11, 2025

Choose a reason for hiding this comment

Uh oh!

karthikjeeyar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

karthikjeeyar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Eswaraiahsapram commented Mar 14, 2025

Uh oh!

karthikjeeyar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonarqubecloud Bot commented Mar 17, 2025

Quality Gate passed

Uh oh!

karthikjeeyar left a comment

Choose a reason for hiding this comment

Uh oh!

rohitkrai03 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Eswaraiahsapram commented Mar 4, 2025 •

edited

Loading

rhdh-gh-app Bot commented Mar 4, 2025 •

edited

Loading

Eswaraiahsapram commented Mar 11, 2025 •

edited

Loading