Skip to content

Fix Hasura Count Aggregation Filter - #1378

Merged
omeraplak merged 2 commits into
refinedev:masterfrom
narayanpromax:aggregation-filters-patch
Dec 28, 2021
Merged

Fix Hasura Count Aggregation Filter#1378
omeraplak merged 2 commits into
refinedev:masterfrom
narayanpromax:aggregation-filters-patch

Conversation

@narayanpromax

Copy link
Copy Markdown
Contributor

Aggregation Filters patch
Aggregation Operation Spelling

Closing issues

Put closes #1377 in your comment to auto-close the issue that your PR fixes (if such).

Aggregation Filters patch
Aggregation Operation Spelling
@omeraplak omeraplak linked an issue Dec 20, 2021 that may be closed by this pull request
@omeraplak

Copy link
Copy Markdown
Contributor

Hey @narayandreamer ,
Great! Can we merge this PR? Or is it still in WIP status?

@omeraplak omeraplak changed the title WIP: Update index.ts [Bug] Fix Hasura Count Aggregation Filter Dec 20, 2021
@omeraplak omeraplak changed the title [Bug] Fix Hasura Count Aggregation Filter Fix Hasura Count Aggregation Filter Dec 20, 2021
@narayanpromax

Copy link
Copy Markdown
Contributor Author

It's WIP, Could you tell me how to build dist folder in hasura package so that I can test and then remove WIP?

@omeraplak

Copy link
Copy Markdown
Contributor

It's WIP, Could you tell me how to build dist folder in hasura package so that I can test and then remove WIP?

Ohh okay. Our document about local development,
https://refine.dev/docs/contributing/#running-in-development-mode

If you want to run specific projects you can use Lerna's filters,
https://github.com/lerna/lerna/tree/main/core/filter-options

Don't forget to make sure the path of the project you want to run is in lerna.json,
https://github.com/pankod/refine/blob/master/lerna.json#L2

For Hasura example,

{
  "packages": [
    "packages/*",
    "examples/dataProvider/hasura"
  ],
  "registry": "https://registry.npmjs.org/",
  "npmClient": "npm",
  "publishConfig": {
    "access": "public"
  },
  "version": "2.4.11"
}

example;

npm install
npm run bootstrap
npm run build
npm run start -- --scope @pankod/refine --scope @pankod/refine-hasura --scope refine-hasura-example

Comment thread packages/hasura/src/index.ts
@omeraplak
omeraplak merged commit c8cd6d4 into refinedev:master Dec 28, 2021
@omeraplak

Copy link
Copy Markdown
Contributor

Hey @narayandreamer ,
We've tested your PR and works very well. Congrats! Thank you

@narayanpromax
narayanpromax deleted the aggregation-filters-patch branch December 29, 2021 17:26
@narayanpromax

Copy link
Copy Markdown
Contributor Author

Hi @omeraplak . Sorry I was AFK last week so couldn't update you. Cool it works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Hasura Count Aggregation Filter

2 participants