[Improvement] Move getDefaultFilter and getDefaultSorter to core package - #1799
Merged
Conversation
Contributor
Hello from PR HelperIs your PR ready for review and processing? Mark the PR ready by including If you still have work to do, even after marking this ready. Put the PR on hold by including |
refine-bot
requested review from
biskuvit,
ozkalai,
salihozdemir and
yildirayunlu
May 12, 2022 13:58
biskuvit
approved these changes
May 12, 2022
ozkalai
approved these changes
May 12, 2022
salihozdemir
approved these changes
May 13, 2022
yildirayunlu
approved these changes
May 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test me! 'MASTER'
Link to REFACTOR-GET-DEFAULT-FILTER-AND-SORTER
Please provide enough information so that others can review your pull request:
We also needed the getDefaultFilter and getDefaultSorter helper functions in the "@pankod/refine-mui" package. We moved these two functions from
@pankod/refine-antdpackage to@pankod/refine-core. We also marked it as deprecated in the@pankod/refine-antdpackage but this does not cause a Breaking Change 🎉