Skip to content

Fix useForm initialValues issue - #1823

Merged
omeraplak merged 3 commits into
masterfrom
fix-antd-form-initial-values
May 23, 2022
Merged

Fix useForm initialValues issue#1823
omeraplak merged 3 commits into
masterfrom
fix-antd-form-initial-values

Conversation

@omeraplak

@omeraplak omeraplak commented May 23, 2022

Copy link
Copy Markdown
Contributor

Test me! 'MASTER'
Link to FIX-ANTD-FORM-INITIAL-VALUES

Hey, I'm client! Test me! 'MASTER'
Link to FIX-ANTD-FORM-INITIAL-VALUES

Test me! 'MASTER'
Link to FIX-ANTD-FORM-INITIAL-VALUES

Please provide enough information so that others can review your pull request:

Ant Design Form's setFieldsValue method was making all fields touched. it's better to use initialValues instead

Closing issues

@refine-bot

Copy link
Copy Markdown
Contributor

Hello from PR Helper

Is your PR ready for review and processing? Mark the PR ready by including #pr-ready in a comment.

If you still have work to do, even after marking this ready. Put the PR on hold by including #pr-onhold in a comment.

@omeraplak
omeraplak merged commit b28f992 into master May 23, 2022
@omeraplak
omeraplak deleted the fix-antd-form-initial-values branch May 23, 2022 10:33
@clebeaupin

Copy link
Copy Markdown

Hello,
Since this fix, I have an issue on useModalForm hook.

const { show, modalProps, formProps, } = useModalForm<Project>({ resource: "applicationProjects", action: "edit", redirect: false, });

formProps.initialValues are always empty.

I don't know if my issue is related to this fix but for my case I have to go back to @pankod/refine-antd@3.20.1 to have a working modal form.

@omeraplak

omeraplak commented May 23, 2022

Copy link
Copy Markdown
Contributor Author

Hey @clebeaupin ,
Thank you for contacting us. Probably related to this release. We will release a fix tomorrow. Thank you for your understanding 🚀Could you create an issue?

@omeraplak

Copy link
Copy Markdown
Contributor Author

We've created #1827 . We will release it today 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants