Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Jun 15, 2019

Also:

  • Remove the JobState abstraction, because it does not offer anything for the moment.
  • Update Slurm job states.

Fixes #833.

Vasileios Karakasis added 2 commits June 13, 2019 17:40
This fixes ReFrame being stuck when a job is killed due to OOM.
Also:

- Remove the `JobState` abstraction, because it does not offer anything
  for the moment.
@codecov-io
Copy link

codecov-io commented Jun 15, 2019

Codecov Report

Merging #835 into master will decrease coverage by 0.03%.
The diff coverage is 39.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #835      +/-   ##
==========================================
- Coverage   91.87%   91.84%   -0.04%     
==========================================
  Files          80       80              
  Lines       10277    10246      -31     
==========================================
- Hits         9442     9410      -32     
- Misses        835      836       +1
Impacted Files Coverage Δ
reframe/core/schedulers/local.py 98.87% <100%> (-0.06%) ⬇️
reframe/core/schedulers/__init__.py 95.83% <100%> (+1.63%) ⬆️
reframe/core/schedulers/slurm.py 55.92% <13.33%> (-3.15%) ⬇️
unittests/test_schedulers.py 97.65% <75%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 971f305...5055e35. Read the comment docs.

Copy link
Contributor

@teojgo teojgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak merged commit 8255fa1 into reframe-hpc:master Jun 17, 2019
@vkarak vkarak deleted the bugfix/handle-oom-slurm branch June 17, 2019 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ReFrame gets stuck if job is OOM killed

3 participants