feat: wire up Datadog RUM for client-side monitoring - #1764
Merged
Conversation
Adds @datadog/browser-rum + @datadog/browser-rum-react, initialized via a client-only DatadogInit component mounted in the root layout. Session replay is explicitly disabled (sessionReplaySampleRate: 0) since it would visually record the editor UI, which cuts against Reframe's "100% private" positioning — metrics/errors only. applicationId/clientToken are read from NEXT_PUBLIC_* env vars (documented in .env.example), never hardcoded. Not pushed: src/app/privacy/page.tsx currently states Reframe "does not embed analytics SDKs" and collects "no analytics, telemetry ... of any kind" — directly contradicted by this change. Needs a wording pass before this goes near main. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L5gqyU5QKQtLAza6hL6dXv
Contributor
👋 Thanks for your PR, @magic-peach!Welcome to Reframe — a browser-based video editor built for everyone 🎬 What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
github-actions
Bot
added
level:intermediate
Contributor
|
Sections 1 and 3 previously stated Reframe embeds no analytics SDKs and collects no telemetry of any kind — false as of the Datadog RUM integration. Rewrites both to accurately describe what's actually collected (anonymous page views, load performance, JS errors), explicitly states session replay is off, and clarifies telemetry can never include video/audio content since that data never leaves the browser regardless. Section 8's "absence of telemetry" claim updated to match. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L5gqyU5QKQtLAza6hL6dXv
main picked up the org rename (#1756) and the phantom-submodule fix (#1765) since this branch was created; both landed cleanly. bun.lock had a real conflict (main gained Snyk's dependency, this branch gained the Datadog RUM packages) — resolved by regenerating the lockfile via `bun install` against the merged package.json rather than hand-editing conflict markers. tsc --noEmit, lint, and build all verified clean post-merge. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L5gqyU5QKQtLAza6hL6dXv
✅ Deploy Preview for reframe-os ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
magic-peach
marked this pull request as ready for review
September 2, 2026 12:03
Contributor
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Contributor
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@datadog/browser-rum+@datadog/browser-rum-react, initialized via a client-onlyDatadogInitcomponent mounted in the root layout.sessionReplaySampleRate: 0— deliberately off. Session replay would visually record the editor UI, which cuts against Reframe's "100% private" positioning; metrics/errors only (sessionSampleRate: 100).applicationId/clientTokenare read fromNEXT_PUBLIC_DATADOG_APPLICATION_ID/NEXT_PUBLIC_DATADOG_CLIENT_TOKEN(documented in.env.example), never hardcoded. These need to be set in Vercel/Netlify's build environment (NEXT_PUBLIC_* vars are inlined at build time for this static export) for RUM to actually activate — with them unset,DatadogInitno-ops.Draft — blocking issue, not ready to merge
src/app/privacy/page.tsxcurrently states, in its own words:Both are directly contradicted by this change. This needs a wording pass on the privacy policy before merge — left as a draft until that's resolved.
Test plan
bunx tsc --noEmitcleanbun run lintcleanbun run buildsucceeds (static export)NEXT_PUBLIC_DATADOG_*env vars in a preview deploy and confirm events land in the Datadog RUM dashboard🤖 Generated with Claude Code
https://claude.ai/code/session_01L5gqyU5QKQtLAza6hL6dXv