fix(security): harden scope, trust, and release boundaries#471
Merged
Conversation
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 69311802dc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jeremi
enabled auto-merge (rebase)
July 25, 2026 03:52
This was referenced Jul 25, 2026
This was referenced Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
contents: writeand OIDC permissionsrepository_dispatch, with checkout credentials disabledComponent reviews
The final integration keeps the original three signed commits while each independent owning area has a narrow review unit:
registryctlauthorization-scope isolationThe component PRs are review-only stacks and should not be merged separately. This PR remains the single final merge to
mainafter those reviews complete.Why
A security review identified four boundary failures: authored scopes could collapse distinct capabilities, a configured private database root was additive to system trust, downloaded build artifacts were executed in a privileged publication job, and the backfill workflow could run branch-selected workflow code with write authority.
The changes apply the smallest controls at those boundaries. They do not broadly restrict reviewed project configuration or add unnecessary operator approvals.
User and operator impact
root_certificate_pathcontinue using the host system trust storegh apiinvocation so privileged implementation always comes from the default branchValidation
cargo fmt --all -- --checkcargo test --locked -p registryctl(291 passed)cargo clippy --locked -p registryctl --all-targets -- -D warningscargo test --locked -p registry-relay --lib(719 passed, 6 ignored)cargo clippy --locked -p registry-relay --lib --tests -- -D warningsjust ci-preflightincrates/registry-relaypython3 -m unittest release/scripts/test_registry_release.py(66 passed)python3 -m unittest release/scripts/test_check_release_source_model.py(12 passed)actionlint .github/workflows/release.yml .github/workflows/release-capsule-backfill.ymlgit diff --checkTwo independent implementation reviews found no actionable code issue. The component PRs provide the requested owning-area review split.