fix(relay): reject non-exclusive Android trust roots#478
Merged
Conversation
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
…rust-root-20260725 Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
native-tlsreloads Android's system certificate directory after clearing the OpenSSL root store, so the exclusive trust-root guarantee introduced by #471 cannot be enforced on that platform. Rejecting this configuration is the smallest safe behavior.This follow-up was identified by Codex review on the review-only component PR #475 immediately before #471 merged.
Verification
cargo test --locked -p registry-relay --lib(720 passed, 6 ignored)cargo clippy --locked -p registry-relay --lib --tests -- -D warningscargo fmt --checkgit diff --checkAndroid cross-compilation was not run because the Android Rust target is not installed.
Signed-off-by: Jeremi Piotrowski jpiotrowski@worldbank.org